#1435 changes for writeInheritanceData should not contain duplicated parent_id
Closed: Fixed by mikem. Opened by julian8628.

duplicated parent_ids will cause inconsistency like:

$ koji call getInheritanceData 48
[]
$ koji call setInheritanceData 48 --kwargs "{'data':[{'parent_id': 350, 'delete link': True, 'priority': 10, 'maxdepth': None, 'intransitive': False, 'noconfig': False, 'pkg_filter': ''},{'parent_id': 350, 'priority': 10, 'maxdepth': None, 'intransitive': False, 'noconfig': False, 'pkg_filter': ''}]}"
None
$ koji call getInheritanceData 48
[{'child_id': 48,
  'intransitive': False,
  'maxdepth': None,
  'name': 'test-parent-tag',
  'noconfig': False,
  'parent_id': 350,
  'pkg_filter': '',
  'priority': 10}]
$ koji call setInheritanceData 48 --kwargs "{'data':[{'parent_id': 350, 'delete link': True, 'priority': 10, 'maxdepth': None, 'intransitive': False, 'noconfig': False, 'pkg_filter': ''},{'parent_id': 350, 'priority': 10, 'maxdepth': None, 'intransitive': False, 'noconfig': False, 'pkg_filter': ''}]}"
None
$ koji call getInheritanceData 48
[]

PR #1434

Commit fc0f1272 fixes this issue

Metadata Update from @julian8628:
- Issue set to the milestone: 1.18

Commit 5c40091b relates to this ticket

Commit 8845b9eb relates to this ticket

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1435

Please continue any further discussion there.

Metadata
Related Pull Requests