koji

#1472 prePackageListChange shouldn't be called if change will not happen
Closed: Fixed by tkopecek. Opened by tkopecek.

Closed: Fixed
Reopen Issue

There is no action made in _direct_pkglist_add, if there are no changes and force is not specified. In such case prePackageListChange callback is emitted, but not post-one. So, there are two problems - a) inconsistent pre/post sequence and b) it doesn't make sense to call 'pre' part anyway.

PR 3403

Metadata Update from @jcupova:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.30

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Commit c1643daa fixes this issue

Commit f31d92df fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1472

Please continue any further discussion there.
Metadata
None

bug testing-done testing-ready

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.