#1507 list_archive_files does not handle multi-type builds
Closed: Fixed by mikem. Opened by mikem.

If a build has both maven and win btypes, and you call listArchiveTypes on one of its non-maven archives, then the call errors because it assumes the archive is a maven archive.

Traceback (most recent call last):
  File "/usr/share/koji-hub/kojixmlrpc.py", line 228, in _wrap_handler
    response = handler(environ)
  File "/usr/share/koji-hub/kojixmlrpc.py", line 271, in handle_rpc
    return self._dispatch(method, params)
  File "/usr/share/koji-hub/kojixmlrpc.py", line 308, in _dispatch
    ret = koji.util.call_with_argcheck(func, params, opts)
  File "/usr/lib/python2.7/site-packages/koji/util.py", line 216, in call_with_argcheck
    return func(*args, **kwargs)
  File "/usr/share/koji-hub/kojihub.py", line 4399, in list_archive_files
    maven_archive = get_maven_archive(archive_info['id'], strict=True)
  File "/usr/share/koji-hub/kojihub.py", line 4283, in get_maven_archive
    return _singleRow(select, locals(), fields, strict=strict)
  File "/usr/share/koji-hub/kojihub.py", line 4565, in _singleRow
    row = _fetchSingle(query, values, strict)
  File "/usr/share/koji-hub/kojihub.py", line 4541, in _fetchSingle
    raise koji.GenericError('query returned no rows')
GenericError: query returned no rows

This breaks the archiveinfo web page for said archive.

Metadata Update from @mikem:
- Custom field Size adjusted to None

PR #1508 fixes the archiveinfo page for me

Is this identical to #1467?

Is this identical to #1467?

Ah, I guess it is. Will mark that as a dup since this one has the PR

Metadata Update from @mikem:
- Issue set to the milestone: 1.19

Commit 92fcb60e fixes this issue

Commit 2a00b1a7 fixes this issue

Metadata Update from @jcupova:
- Issue tagged with: testing-done

Metadata Update from @dgregor:
- Issue assigned to mikem

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1507

Please continue any further discussion there.

Metadata
Related Pull Requests