Issue #1610: [RFE] Cancel CG reservation - koji

koji

#1610 [RFE] Cancel CG reservation

Closed: Fixed Oct 16, 2019 by tkopecek. Opened Aug 12, 2019 by tkopecek.

CG can want to cancel its reservation before it gets garbage-collected (e.g. when failing build). There are two options:

make it a part of failBuild(release_reservation=True) - in such case it could work - releasing it every time could lead to race conditions.
make a separate API call CGReleaseReservation

Another option is to implement both of these (internally sharing same code).

mikem commented Aug 12, 2019

The only failBuild is host.failBuild, so I think there has to be a new call.

Also, I can see giving the CG the option of marking it canceled too.

Metadata Update from @mikem:
- Custom field Size adjusted to None

Aug 12, 2019

tkopecek commented Aug 14, 2019

If we have CGInitBuild, maybe CGUnitBuild(state=koji.CANCELED) with possible other option value koji.FAILED would be ok. Or better idea for naming? I don't think, that such call should be used anywhere outside of CG API, so I would leave it in "CG" namespace.