Issue #1661: Configure python's logging module in koji's config - koji

koji

#1661 Configure python's logging module in koji's config

Closed: Fixed Oct 31, 2019 by tkopecek. Opened Sep 26, 2019 by pingou.

I would be really beneficial to be able to configure python's logging module from koji's configuration file.

For example, in koji-fedmsg-plugin we are using logging to log exceptions. However, since no handler is defined anywhere, these logs are entirely lost.
This has prevented us from finding more quickly a bug we had in this code (up until we thought about printing the exceptions).

So it would be nice if we could configure/tweak the logging configuration via koji's configuration :)

There are a few ways to do this (using ini, json, yaml) documented in the upstream's module doc: https://docs.python.org/3/howto/logging.html#configuring-logging

Thanks! :)

julian8628 commented Sep 26, 2019

@pingou
"LogLevel" and "LogFormat" in /etc/koji-hub/hub.conf are for this purpose
for example:

LogLevel = koji:INFO koji-fedmsg-plugin:DEBUG
LogFormat = %(asctime)s [%(levelname)s] m=%(method)s u=%(user_name)s p=%(process)s r=%(remoteaddr)s %(name)s: %(message)s