koji

#1729 koji CLI still checks for admin permission instead of tag/target/host
Closed: Fixed by tkopecek. Opened by cobrien.

Closed: Fixed
Reopen Issue

PR #1454 introduced new permissions that gate hub calls for working with tags, targets, and hosts.

However, the koji CLI still marks the CLI commands that trigger those hub calls as admin commands, and the command handlers check for the admin permission before even attempting to make the hub call.

Thus for example, a user with the tag permission will receive the error
"This action requires admin privileges" when running koji add-tag foo-bar-baz

But can successfully run koji call createTag foo-bar-baz

Metadata Update from @tkopecek:
- Custom field Size adjusted to small
- Issue set to the milestone: 1.20
- Issue tagged with: bug

Submitted PR https://pagure.io/koji/pull-request/1730 against the 1.18 updates branch
Edited by cobrien

Submitted PR https://pagure.io/koji/pull-request/1733 against master

Commit 353eefea fixes this issue

This couldn't make it into 1.19? That's why I rushed to get the fix PR created... the major permissions feature from 1.18 is effectively non-existent without the fix in place.

Sorry, it appeared after code-freeze. But we can backport it for you internally.

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.19.1 (was: 1.20)

Metadata Update from @jcupova:
- Issue tagged with: testing-done

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1729

Please continue any further discussion there.
Metadata
None

bug testing-done

None
None
Low
small
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.