#2101 CLI clone-tag with options --repo, --ts, --event
Closed: Fixed by mikem. Opened by jcupova.

CLI method clone-tag has options contains --repo, --ts and --event also. These three options are not used for any functionality now. It should be great to think about the functions of these options or drop them.

@julian8628 @tkopecek @mikem Do you have any idea?


Metadata Update from @jcupova:
- Custom field Size adjusted to None
- Issue tagged with: discussion

These three options are not used for any functionality now.

I'm not sure what you mean.

These options provide three different ways to specify a point in time from which to clone. They allow you, for example, to clone the tag as it was a month ago.

At the beginning of the handler, we have the following:

    event = koji.util.eventFromOpts(session, options) or {}
    if event:
        event['timestr'] = time.asctime(time.localtime(event['ts']))
        print(_("Cloning at event %(id)i (%(timestr)s)") % event)

The eventFromOpts function reads theses three options and returns appropriate event info.

The event value determined here is used throughout the handler to query the src tag at the given event rather that the present time.

However, it does look like we overlooked that in the initial getTag call.

Ah, I've missed evenFromOpts usage. So, let's use this ticket for fixing getTag.

Metadata Update from @tkopecek:
- Custom field Size adjusted to small (was: None)
- Issue untagged with: discussion
- Issue set to the milestone: 1.22
- Issue tagged with: bug

PR: #2364

Metadata Update from @julian8628:
- Issue tagged with: easyfix, testing-ready

Metadata Update from @jcupova:
- Issue tagged with: testing-done

Commit 43db33ea fixes this issue

Commit 45a4867e fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2101

Please continue any further discussion there.

Metadata
Related Pull Requests