#2116 Split CLI to files per command
Closed: Dropped by mikem. Opened by tkopecek.

It would be easier for other people's involvement and tests shows, that there is almost no difference in speed of loading.


PoC https://pagure.io/fork/tkopecek/koji/branches?branchname=split-cli

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.23 (was: 1.22)

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.24 (was: 1.23)

Metadata Update from @tkopecek:
- Issue set to the milestone: None (was: 1.24)

@mikem I had a discuss with @tkopecek about this issue, that we continue work on it. We spoke about it that we can modernize it by click library. Mike, what do you think to update CLI with click library and split CLI?

While I like click and have used it for some other projects, I'm not sure it's a good fit for Koji.

In any case, I think the split should be done separately. It would be too much change all at once.

@mikem Idea was to find something fitting - not use click without considering other options. Question is if it is worth to split CLI now or wait for that solution and "maybe" make some other structuring.

The split seems like a pretty safe change as long as we only do the split and do not otherwise refactor the code. I don't think there's a strong technical reason for it, but istr there were a few people in the community asking for it.

Given how overloaded we have been, I wouldn't want to devote a lot of time to it. However if we can do it quickly, then sure.

PR #3399

Dropping this for now, but may revisit in the future

Metadata Update from @mikem:
- Issue close_status updated to: Dropped
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2116

Please continue any further discussion there.

Metadata
Related Pull Requests