koji

#2221 download_rpm can fail with some sigmd5s
Closed: Fixed by tkopecek. Opened by tkopecek.

Closed: Fixed
Reopen Issue

Some rpms use different headers, see comments in kojihub / add_rpm_sig Checking function in CLI can now refuse to download such rpm.

PR #2222

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

The example failure that was given to me involved the sigmd5 value getting mangled because the original bytes value had been decoded to a string, and then encoded as a hex string. In some cases the binary sum would break that fragile process. The problem is I think when the binary md5 manages to be valid unicode and include multibyte characters.

In the case I was given, the md5 was: 26007b694b41392d76122e05c289dc8c

This decodes as: '&\x00{iKA9-v\x12.\x05\x89܌'

That last two characters are multibyte and hex_string gets this wrong because it is iterating over the characters of the string.
Edited by mikem

2268 addresses the latter issue. If there are other examples that fail for different reasons, please bring them up.

Commit a492140d fixes this issue

Commit b3687f2b fixes this issue

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.21.1 (was: 1.22)

'testing-ready' tag was removed for testing purposes, will be reverted soon

Metadata Update from @mfilip:
- Issue untagged with: testing-ready

Metadata Update from @mfilip:
- Issue tagged with: testing-ready

Metadata Update from @jcupova:
- Issue tagged with: testing-done

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2221

Please continue any further discussion there.
Metadata
None

bug testing-done testing-ready

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.