#2260 Fix repo defaults for livemedia builds
Closed: Fixed by tkopecek. Opened by breilly.

Livemedia builds do not operate the same as livecd builds when choosing a default install tree / repo. This should be changed so livemedia builds do not replace existing repos defined in kickstarts, which is the behavior for livecd builds.


Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.23

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.24 (was: 1.23)

So, the livecd code is some of the earliest image building code in Koji. The repo substitution behavior is something that all the more recent image building code has. We certainly don't want to remove this feature for livemedia builds.

That said, I think it should be ok to provide a way to turn it off.

At the moment, the prepareKickstart function that does this looks at the repo option for the image build, which is used to replace the repos in the kickstart. If that option is not given, then the repo for the build tag is used instead.

For backwards compatibility, I think we need to preserve the default. We could either use some sort of sentinel value in the repo option to mean "just leave the repos alone", or we could add a new option. The latter would probably be clearer.

We could also possibly have Koji take a cue from tag.extra data on this, perhaps even letting tag.extra change the default behavior.

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Metadata Update from @jcupova:
- Issue tagged with: testing-done

Commit 3b2b7cea fixes this issue

Commit b97813d6 fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2260

Please continue any further discussion there.

Metadata
Related Pull Requests