koji

#2282 merge localPath() and openRemoteFile() - they both download srpm on the builder
Closed: Dropped by tkopecek. Opened by sharkcz.

Closed: Dropped
Reopen Issue

There are 2 functions that download srpms - tasks.py/loadPath() for buildArch tasks and __init__.py/openRemoteFile() for build tasks (the srpm will be later used in the buildArch tasks), it would be useful to merge them. For reasons please see our debugging efforts in #1974

Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.23

Metadata Update from @tkopecek:
- Issue priority set to: Low (was: Normal)
- Issue set to the milestone: 1.24 (was: 1.23)
- Issue tagged with: tech-debt

Metadata Update from @tkopecek:
- Issue set to the milestone: None (was: 1.24)

It looks like there was some refactoring in commit 3d698be2a7779a1d21b649c9942155b288294d1f
Is further merging still needed?

I'm more for closing this one. Merging them further would need more changes. openRemoteFile returns fd for the open temporary file, while the localPath treats the file as more permanent, thus returning file path. Merging them together would mean more logical changes.

ok, no objections from my side

Metadata Update from @tkopecek:
- Issue close_status updated to: Dropped
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2282

Please continue any further discussion there.
Metadata
None

tech-debt

None
None
Normal
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.