Issue #231: Koji (koji-web) fails in Fedora 25 with DateTime instance has no attribute 'rfind' - koji

koji

#231 Koji (koji-web) fails in Fedora 25 with DateTime instance has no attribute 'rfind'

Closed: Fixed Jan 17, 2017 Opened Dec 7, 2016 by amessina.

File "/usr/share/koji-web/scripts/wsgi_publisher.py", line 387, in handle_request
result = func(environ, **data)
File "/usr/share/koji-web/scripts/index.py", line 317, in index
return _genHTML(environ, 'index.chtml')
File "/usr/share/koji-web/lib/kojiweb/util.py", line 147, in _genHTML
return tmpl_inst.respond().encode('utf-8', 'replace')
File "index_chtml.py", line 151, in respond
File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 2419, in formatTime
dotidx = value.rfind('.')
AttributeError: DateTime instance has no attribute 'rfind'

amessina commented Dec 7, 2016

Related to #230

mikem commented Dec 8, 2016

I wonder if this one and #230 are helped by this patch:

https://pagure.io/fork/mikeb/koji/c/676db88a8bd4c729278ef4594c9174be5b554b2f

amessina commented Dec 9, 2016

I suppose I could git it a try if you're interested in merging it for the next release. Is that what you're wondering? ;)

amessina commented Dec 10, 2016

@mikem, I can confirm that applying your patch https://pagure.io/fork/mikeb/koji/c/676db88a8bd4c729278ef4594c9174be5b554b2f (and removing PyGreSQL for good measure) resolves the issue on a Fedora 25 installation.

amessina commented Dec 10, 2016

mikem commented Dec 10, 2016

Thanks!
That patch needs more testing, but I think it might be the way we need to go now. It looks like PyGreSQL introduced many incompatible changes in 5.0.

mizdebsk commented Dec 11, 2016

Reproducible for me as well, koji-web falis with this (and other) errors when talking to hub deployed on Fedora 25. Combination of hub/f24 and web/f25 works fine.

tkopecek commented Dec 13, 2016

@mikem Are we going to fix these issues with PyGreSQL or migrate to psycopg2?

ngompa commented Dec 13, 2016

@mikem @tkopecek For what it's worth, I went ahead and applied the patch to migrate to psycopg2 downstream in the Koji package for Mageia.

mizdebsk commented Dec 13, 2016

I've tested the psycopg2 patch from @mikeb (rebased to 1.11.0 by @ngompa) and it fixes the problem on Fedora 25.

mikem commented Dec 13, 2016

There may be some corner issues with the psychopg2 patch, so beware

tkopecek commented Dec 14, 2016

I've opened PR #240 for discussion about psycopg2 solution.

mikem commented Jan 17, 2017

Commit 1b9e04b0 fixes this issue