#2479 Replace --old-chroot with --isolation=simple
Opened by msuchy. Modified

Koji calls Mock with --old-chroot:

$ git grep old-chroot
builder/kojid:                cmd.append('--old-chroot')
docs/source/release_notes/release_notes_1.16.rst:**Add --old-chroot option to runroot command**
docs/source/release_notes/release_notes_1.16.rst:If neither ``--old-chroot`` or ``--new-chroot`` is given, then mock will
docs/source/using_the_koji_build_system.rst:  `--old-chroot` option is appended to any mock call. If it is not set,
koji.spec:- PR#823: Add --old-chroot option to runroot command
plugins/builder/runroot.py:                mock_cmd.append('--old-chroot')
plugins/cli/runroot.py:    parser.add_option("--old-chroot", action="store_false", default=None, dest='new_chroot',
plugins/cli/runroot.py:                      help=_("Run command with the --old-chroot (systemd-nspawn) option to mock"))

Mock now prefers to use --isolation=simple and emits this warning:

ERROR: Option --old-chroot has been deprecated. Use --isolation=simple instead.

This option is available since mock-2.0-1.

CC FYI @praiskup


@msuchy @praiskup Is there ETA when --old-chroot will be remove completely? For now it is easier for me to use it and not test mock's version for proper option.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue tagged with: tech-debt

That backward-compat option isn't expensive for maintenance ATM, but we don't test it. There's no ETA.

You can enforce it by Requires. But all stable versions of EPEL/Fedora have version higher than 2.0. I think you can safely expect that that this option is recognized.

I bet there's still support for things like EL6 builders (plus very old mock), etc.

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2479

Please continue any further discussion there.

Metadata