#2497 getLastHostUpdate returns time only as a string
Closed: Fixed by tkopecek. Opened by mikem.

In general, Koji hub calls return times as both a text field and an integer field. The text field does not have a strictly defined format and has changed over time (e.g. the issue in #2423, caused by the changes from #2160).

I generally recommend that clients that need to process times beyond just displaying the returned string use the integer fields (typically ending in _ts). However this call only returns the string.

Since the return here is single valued. I think the best way to address this without breaking the api is to add a flag to the call to request a timestamp instead.

If we make this change, we might also want to use that option in the cli and web interfaces where we use this call.


Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.24

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.25 (was: 1.24)

Metadata Update from @tkopecek:
- Issue untagged with: discussion
- Issue tagged with: testing-ready

Looks like check for invalid host_id input is missing:

[ERROR] koji: Fault: : 'NoneType' object has no attribute 'timestamp'">

Metadata Update from @jobrauer:
- Issue tagged with: testing-done

Commit f7a63384 fixes this issue

Commit 9dc0efd4 fixes this issue

Metadata Update from @tkopecek:
- Issue status updated to: Open (was: Closed)

Doesn't work against older hub (e.g. list-hosts will fail)

@tkopecek here is a fix - PR #2798

Metadata Update from @tkopecek:
- Issue untagged with: testing-done

Commit ed262fa2 fixes this issue

Commit 42546751 fixes this issue

Commit 7d49052d fixes this issue

Commit 5006625f relates to this ticket

Metadata Update from @mfilip:
- Issue tagged with: testing-done

One more fix PR 2857

Metadata Update from @jcupova:
- Issue status updated to: Open (was: Closed)

Commit 7d3f34b4 fixes this issue

Commit 5e861978 fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2497

Please continue any further discussion there.

Metadata
Related Pull Requests