Anyway, we've tests in many places that the option is ignored if running in the background. We should unify this.
PR for one case: #2520
Should I update my PR to fix the logic so that if in background, don't wait (and also the CLI docs) ?
@mikem what was the original idea? I expect, that wait should work even if running in background for scripting usage?
Metadata Update from @tkopecek: - Custom field Size adjusted to None
Metadata Update from @tkopecek: - Issue set to the milestone: 1.25 (was: 1.24)
I generally think that commands should do what the user says. If the user passes --wait, then the command should wait.
I think there is a valid use case for this. Some users will run koji build --wait ... && follow up command where the follow up command does something with the build. Such a command pipeline might well be backgrounded or scripted.
koji build --wait ... && follow up command
Also, if it is not already the case, the exit code after waiting should indicate success or failure of the build or task.
New PR 2813 which fixes:
image-build-indirection tag-build
Additional info about PR are in the PR.
Metadata Update from @jcupova: - Issue tagged with: testing-ready
Metadata Update from @jobrauer: - Issue tagged with: testing-done
Commit d7076086 fixes this issue
Commit 56a2d860 fixes this issue
This issue has been migrated to Fedora Forge: https://forge.fedoraproject.org/koji/koji/issues/2522
Please continue any further discussion there.