#2719 Error for download-build and non-existing sigkey should be improved
Closed: Fixed by tkopecek. Opened by mfilip.

Something like "no such key xxxx" would be better.

koji download-build --key=key-x1b2 kojitest-dummyrpm-i4t3d-1.1-11
2021-02-23 01:04:53,853 [ERROR] koji: HTTPError: 404 Client Error: Not Found for url: http://10.0.105.207/kojifiles/packages/kojitest-dummyrpm-i4t3d/1.1/11/data/signed/key-x1b2/src/kojitest-dummyrpm-i4t3d-1.1-11.src.rpm

IMHO it would be nice to keep the 404 error code and URL in the output, though.

It is two separate issues to be checked here. We could/should look to db if signed rpm exists and then raise 404 if it is not found on download server.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.26

Yeah, that's a good idea. Files can be "signed" but there is a small race when the fully signed RPMs are still being written out to disk.

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Commit 58fe3930 fixes this issue

Commit 51e073f4 fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2719

Please continue any further discussion there.

Metadata
Related Pull Requests