koji

#2751 Introduce type hints to (at least) API calls
Closed: Dropped by tkopecek. Opened by tkopecek.

Closed: Dropped
Reopen Issue

As we have py3 hub now, it makes sense to start using more py3 constructs. API calls can have type hints. These can be gradually introduced without breaking anything. Only thing we need to check is if there is no supported distri with python < 3.5.

My idea was that in the future it could be used to some centralized option gatekeeping. If we use typing library or something similar we can refuse invalid requests in kojixmlrpc before passing it to handler itself. But it would be a bit slower, etc. Adding hints themselves doesn't have performance impact and could improve dev experience.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

I've wanted to add more systematic parameter validation checks to the hub calls, but I'm not sure that the type hint system is the right solution for this.

Metadata Update from @tkopecek:
- Issue close_status updated to: Dropped
- Issue status updated to: Closed (was: Open)

Metadata Update from @tkopecek:
- Issue set to the milestone: None (was: 1.25)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2751

Please continue any further discussion there.
Metadata
None

discussion

None
None
Low
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.