Issue #2868: [1.24.1] git user name are not forward to the builder - koji

koji

#2868 [1.24.1] git user name are not forward to the builder

Closed: Fixed Oct 26, 2021 by tkopecek. Opened May 18, 2021 by frank-mdc.

When an user name is needed for the git checkout to build the srpm package, it will lost at the builder.
Sample:
On the client:
koji build --scratch <tagret> 'git+https://<username>@<git server>/<path to repo>#<tag>'
But the check out on the builder(checkout.log) fails with:
fatal: could not read Username for 'https://<git server>': No such device or address
It looks like the user name was not forward from the client to the hub/builder.

tkopecek commented May 18, 2021

User is allowed in git+ssh scheme. Isn't that git server allowing also that option (as a workaround)? We can add support for that anyway.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

May 18, 2021

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.26

May 18, 2021

frank-mdc commented May 18, 2021

Or I am on the total wrong way to set the credentials for the https git access?

tkopecek commented May 18, 2021

It depends - I don't know that repo :-) git+https + user is completely valid usage for git repos. Anyway, vast majoristy of repos we're tackling with has anonymous access via https, so we just hadn't hit git+https+user combination.

Setting credentials is not that easy - we can't pass password from user to builder (it would be visible in too many places), so only administrator can put credentials on every builder (PR #1640). So, mostly only repos accessible without authentication makes sense for end-user. So, we're stripping username intentionally there.

frank-mdc commented May 18, 2021

In that case it is an git repo accessible via git+https with user name + password.
But the password is not an real password. It is only an token with read only permissions.
It works like git hub when using git tokens.

tkopecek commented May 18, 2021

Ok, then we have to add support for that. Added to next release - should be simple change.

frank-mdc commented May 18, 2021

Thanks :thumbsup:

Metadata Update from @tkopecek:
- Issue tagged with: feature

May 18, 2021

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.27 (was: 1.26)

Aug 9, 2021

jcupova commented Oct 12, 2021

PR 3067

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

Oct 18, 2021