Issue #2917: Policy can fail on deleted tags - koji

koji

#2917 Policy can fail on deleted tags

Closed: Fixed Sep 21, 2021 by tkopecek. Opened Jun 18, 2021 by mikem.

If a tag has been deleted and it comes up in a policy check (e.g. in policy_get_build_tags), then the policy check will fail on get_tag(t, strict=True).

mikem commented Jun 18, 2021

This came up with the side tags plugin. So we have a common workflow where build tags might be deleted for a build that needs to be tagged.

Metadata Update from @mikem:
- Custom field Size adjusted to None

Jun 18, 2021

mikem commented Jun 18, 2021

This issue is not really limited to policy. This is just where it's coming up. See #1506

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.27
- Issue tagged with: bug

Jun 21, 2021

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.26 (was: 1.27)

Jun 22, 2021

tkopecek commented Jun 22, 2021

PR #2923

mikem commented Jun 22, 2021

It turns out #1506 is probably not enough here. Even if the policy successfully gets the deleted taginfo, it will then try to read the inheritance for said tag. Since inheritance entries are also deleted when a tag is deleted, the result will be an empty list, making the check less useful.

Likely we need to have the test be smart about the event to query at. The data is available, but it looks like a bit of work to get it and propagate it to where we need it.

mikem commented Jun 22, 2021

Also, I note that the taginfo option for policy_get_build_tags is not honored in all cases. We should fix that too.

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.27 (was: 1.26)

Aug 11, 2021

tkopecek commented Aug 11, 2021

Moving to next release as we first need #1506 merged.

tkopecek commented Aug 19, 2021

PR #2989

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

Sep 6, 2021

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Sep 21, 2021