Issue #2943: www: rpminfo page does not show human-readable filesize - koji

koji

#2943 www: rpminfo page does not show human-readable filesize

Closed: Fixed Dec 13, 2021 by tkopecek. Opened Jul 8, 2021 by ktdreyer.

The rpminfo web page shows the file size as a simple integer (with comma decimal separators):

<th>Size</th><td>$util.formatThousands($rpm.size)</td>

It's difficult for new users to tell if that means bytes or what.

The humanize library has a method called naturalsize that is great for giving human-readable sizes. For example, with a recent Ceph SRPM:

>>> from humanize import naturalsize
>>> naturalsize(142888690)
'142.9 MB'

ktdreyer commented Jul 8, 2021

humanize is a small dependency

python-humanize-0.5.1-8.el7 is in EPEL 7
python3-humanize-0.5.1-13.el8 is in CentOS Stream 8

ktdreyer commented Jul 21, 2021

This would be really useful in two other areas:

The "Files" table on the rpminfo page
The fileinfo page

Some of the files in Ceph's RPMs are very large, like https://koji.fedoraproject.org/koji/rpminfo?rpmID=26130363 , so it would be nice to see human-readable filesizes at a glance.

Edited Jul 21, 2021 by ktdreyer

tkopecek commented Jul 22, 2021

Isn't adding "Bytes" unit solving it?

I would to leave full value accessible somehow as this number is often first quick check that e.g. downloaded file is not corrupted.

Maybe "Size 67.6 MB (67,645,246 Bytes)" and hover with full size in "Files" table?

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Jul 22, 2021

ktdreyer commented Jul 22, 2021

This seems to work:

diff --git a/www/kojiweb/fileinfo.chtml b/www/kojiweb/fileinfo.chtml
index 07dbe320..f1eef2c1 100644
--- a/www/kojiweb/fileinfo.chtml
+++ b/www/kojiweb/fileinfo.chtml
@@ -1,6 +1,7 @@
 #import datetime
 #from kojiweb import util
 #from urllib.parse import quote
+#from humanize import naturalsize
 #include "includes/header.chtml"
   #if $rpm
@@ -19,7 +20,7 @@
     </tr>
     #end if
     <tr>
-      <th>Size</th><td>$file.size</td>
+      <th>Size</th><td><span title="$file.size bytes">$naturalsize($file.size)</span</td>
     </tr>
     #if 'mtime' in $file and $file.mtime
     <tr>