#3084 Clean up daemon exit codes
Closed: Fixed by tkopecek. Opened by mikem.

This is a follow up to #3040

Since we're normally running through systemd and, after #3040, systemd will restart us on errors, we should be more systematic about our exit codes.

At present, the following situations will lead to kojid exiting with a zero status.

  • SIGTERM / KeyboardInterrupt / SystemExit
  • AuthExpired exception
  • shutdown task handler

I think AuthExpired case should be an error (and hence a restart condition at the systemd level). The others can probably remain as-is.


Commit 9400ed2a fixes this issue

Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue status updated to: Open (was: Closed)

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.28

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

Metadata Update from @jobrauer:
- Issue tagged with: testing-done

Commit bbaadef4 fixes this issue

Commit 2d820f4b fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3084

Please continue any further discussion there.

Metadata
Related Pull Requests