#3147 New exceptions
Opened by tkopecek. Modified

Let's introduce new exceptions but not use them yet. We will wait for another ~2 versions, so clients should know it in. Gather list here. @ktdreyer


Based on: https://github.com/obriencj/koji-smoky-dingo/blob/master/kojismokydingo/init.py

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

The koji/__init__.py file is massive, so I don't want to add new ones there. Let's add a new koji/exceptions.py to match how python-requests organizes requests.exceptions.

Today the koji.convertFault() method iterates over the entire globals().values() list, looking for GenericError classes. It will be straightforward to make it iterate over all the classes in koji.exceptions instead.

PR https://pagure.io/koji/pull-request/3152

Some other ones we might consider:

  • NotPermitted - instead of the more general AuthError
  • NameValidationError - for the new regular expression string validation feature

Metadata Update from @jcupova:
- Issue tagged with: no_qe

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.29 (was: 1.28)

Metadata Update from @tkopecek:
- Issue set to the milestone: None (was: 1.29)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3147

Please continue any further discussion there.

Metadata
Related Pull Requests