koji

#3222 [kiwi] Save results of `make prep`
Closed: Invalid by ignatenkobrain. Opened by ignatenkobrain.

Closed: Invalid
Reopen Issue

As koji is focusing a lot on reproducibility, we already store re-written config.kiwi (with koji repos).

I think we should move make prep into some separate job (together with modification of config.kiwi) - similar to the SRPMBuild. So that anything that was generated would be saved (and injected to the actual kiwi build).

Probably separate task type is not needed, but I'm not sure how easy would it be to find out which files were generated. Probably add some special requirement for the make-prep step?

As Makefile is the part of the configuration repo it doesn't seem necessary to me to save the changed content. If you want to reproduce it locally, you've to clone the repo, run make prep and replace the .kiwi file with the koji-modified one. This should be deterministic (in case when internet access is restricted enough in builder env)

I would say that running make prep is the same as running random autoconf tool in C rpm package. It would change a lot of things which we're not tracking. Uploading changed content makes sense only for thing which are changed by koji.

Do you've some usecase in mind where it would be problematic?

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Fair enough.

Metadata Update from @ignatenkobrain:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3222

Please continue any further discussion there.
Metadata
None
None
None
None
Low
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.