#3302 web ui: noisy error for empty search
Closed: Fixed by tkopecek. Opened by mikem.

If you go to the search page and click seach without entering a query (or simply enter a space), then the response is a mess looking traceback

 An error has occurred on the main server. This could be a software bug, a server configuration issue, or possibly something else.
koji.GenericError: empty search terms
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/koji/__init__.py", line 2811, in _callMethod
    return self._sendCall(handler, headers, request)
  File "/usr/lib/python3.9/site-packages/koji/__init__.py", line 2715, in _sendCall
    return self._sendOneCall(handler, headers, request)
  File "/usr/lib/python3.9/site-packages/koji/__init__.py", line 2775, in _sendOneCall
    ret = self._read_xmlrpc_response(r)
  File "/usr/lib/python3.9/site-packages/koji/__init__.py", line 2787, in _read_xmlrpc_response
    result = u.close()
  File "/usr/lib64/python3.9/xmlrpc/client.py", line 668, in close
    raise Fault(**self._stack[0])
xmlrpc.client.Fault: <Fault 1000: 'empty search terms'>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/usr/share/koji-web/scripts/wsgi_publisher.py", line 388, in handle_request
    result = func(environ, **data)
  File "/usr/share/koji-web/scripts/index.py", line 2545, in search
    results = kojiweb.util.paginateMethod(server, values, 'search', args=(terms, type, match),
  File "/usr/share/koji-web/lib/kojiweb/util.py", line 338, in paginateMethod
    totalRows = getattr(server, methodName)(*args, **kw)
  File "/usr/lib/python3.9/site-packages/koji/__init__.py", line 2365, in __call__
    return self.__func(self.__name, args, opts)
  File "/usr/lib/python3.9/site-packages/koji/__init__.py", line 2830, in _callMethod
    raise err
koji.GenericError: empty search terms

This is a minor inconvenience, but I think we can do better here.


Metadata Update from @tkopecek:
- Custom field Size adjusted to small
- Issue set to the milestone: 1.28.1
- Issue tagged with: easyfix

PR #3303

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Commit 94e27dbc fixes this issue

Commit c94ce026 relates to this ticket

Metadata Update from @jobrauer:
- Issue tagged with: testing-done

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3302

Please continue any further discussion there.

Metadata
Related Pull Requests