koji

#3392 kojid/kojira logging does not play nice with logrotate
Closed: Fixed by tkopecek. Opened by mikem.

Closed: Fixed
Reopen Issue

kojid a long-lived process and logs to /var/log/kojid.log. Many configurations use logrotate on these logs, which can result in the file handler kojid has open pointing to the wrong file (e.g. the .$N logfile, or even a deleted file).

I believe this can be easily addressed by using logging.handlers.WatchedFileHandler, though we might want to make this configurable for compatibilities sake.

kojira suffers the same problem.

What do you think about just logging to stdout? Then you get all the features from systemd's journal

What do you think about just logging to stdout? Then you get all the features from systemd's journal

The systemd config we ship runs kojid with --fg, which cause it to log to stderr (in addition to kojid.log), so we're actually getting both right now. Same with kojira.

It's probably worth adjusting this and giving the admin more control of where the logs go. Arguably, with --fg we probably only log to stderr or just stdout.

While systemd seems nearly universal anymore, I'm not sure I want to require it. Providing simple config for log destination seems pretty straightforward.
Edited by mikem

Metadata Update from @mikem:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.31

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.32 (was: 1.31)

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.33 (was: 1.32)

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.34 (was: 1.33)

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Commit 37d9b5f4 fixes this issue

Commit 9b48b9c0 relates to this ticket

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3392

Please continue any further discussion there.
Metadata
None

testing-done testing-ready

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.