#3461 koji changed behaviour when downloading task rpms
Closed: Fixed by tkopecek. Opened by mvadkert.

Koji changed behaviour when downloading tasks, see the examples below:

$ rpm -q koji
koji-1.28.1-1.fc34.noarch
$ koji download-task --arch noarch --arch x86_64 --arch src 90835853
Downloading [1/15]: python-unversioned-command-3.11.0~rc1-2.fc38.noarch.rpm
[====================================] 100%  10.12 KiB
Downloading [2/15]: python3.11-debugsource-3.11.0~rc1-2.fc38.x86_64.rpm
[====================================] 100%   3.15 MiB
Downloading [3/15]: python3-idle-3.11.0~rc1-2.fc38.x86_64.rpm
...

And with the new version

$ rpm -q koji
koji-1.29.1-4.fc36.noarch
$ koji download-task --arch noarch --arch x86_64 --arch src 90835853
Download files names conflict, use --dirpertask

Version-Release number of selected component (if applicable):
koji-1.29.1-4.fc36.noarch

How reproducible:
100%

Steps to Reproduce:
See description

Actual results:
Koji works differently when downloading tasks.

Expected results:

Original behaviour is kept, same files can be replaced. Koji can report that same files will be overwritten and give the user an option how to avoid overwriting of files via --dirpertask.

Additional info:

This bug breaks Fedora CI and is another breaking change introduced via https://pagure.io/koji/c/6713d1651d73b1b9d5dec37d0c5e0d85fa41a3c5. We should roll back that breaking change and introduce it more carefully. We should start gating koji on Fedora CI validation.


@tkopecek @jcupova can you take a look at this pls? It is causing us significant problems and blocks Fedora CI.

Ok, we can allow to rewrite .src - it is the only "safe" one.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

@tkopecek agreed, thanks

@tkopecek PR 3462

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Metadata Update from @jcupova:
- Issue set to the milestone: 1.30

Metadata Update from @mfilip:
- Issue untagged with: testing-ready

Testing ready tag was temporarily removed to avoid conflict in testing

Metadata Update from @mfilip:
- Issue tagged with: testing-ready

Commit d81033c7 fixes this issue

Commit c1f7b9db fixes this issue

Metadata Update from @jcupova:
- Issue tagged with: testing-done

new fix PR 3478

note about PR: order download tasks by task ID and download only first srpm

Metadata Update from @jcupova:
- Issue status updated to: Open (was: Closed)

Commit 20b809e0 fixes this issue

Commit cb5515ac fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3461

Please continue any further discussion there.

Metadata
Related Pull Requests