Issue #3499: recent download-task changes incompatible with previous behavior - koji

koji

#3499 recent download-task changes incompatible with previous behavior

Closed: Fixed Oct 3, 2022 by tkopecek. Opened Sep 13, 2022 by mikem.

We merged #3343 back in June 2022, and it was included in 1.29.1. This PR introduces a number of behavior changes that are inconsistent with the previous behavior of the command.

In general, users expect that a Koji command that has worked for them in the past will continue to do so in future version and in much the same way.

This change has resulted in multiple issues in Fedora:

https://bugzilla.redhat.com/show_bug.cgi?id=2118410
https://bugzilla.redhat.com/show_bug.cgi?id=2118011
https://bugzilla.redhat.com/show_bug.cgi?id=2116674

It seems like the scope of the changes went well beyond the issue they were targetting (#3182).

mikem commented Sep 13, 2022

At the point, the new behavior has survived into a major release (1.30), so it is not clear to me if we can change it back at this point. However, we may need to reconcile our behavior with the patches that Fedora has applied.

Metadata Update from @mikem:
- Custom field Size adjusted to None

Sep 13, 2022

Metadata Update from @mikem:
- Issue set to the milestone: 1.30.1

Sep 13, 2022

jcupova commented Sep 14, 2022

@mikem
1st bugzilla issue: ok, I discussed it with Tomas and I create a new PR to fix that when there will be the same files and download-task will be without --dirpertask, it downloads all files and add info that 'list of files' were rewrite and user should user --dirpertask.
2nd bugzilla issue: as it is written in bugzilla, it is fixed
3rd bugzilla issue: it is also fixed by https://pagure.io/koji/pull-request/3459#request_diff

jcupova commented Sep 15, 2022

PR 3502

Metadata Update from @jcupova:
- Issue tagged with: testing-ready

Sep 16, 2022

Metadata Update from @jobrauer:
- Issue tagged with: testing-done

Oct 3, 2022

tkopecek commented Oct 3, 2022

Commit d0983b42 fixes this issue

tkopecek commented Oct 3, 2022

Commit 293f7508 fixes this issue

mikem commented Apr 22, 2026

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3499