#3665 I can assign closed task (with --force)
Opened by tkopecek. Modified

It is affecting already finished tasks.


@mikem Is there any reason that we can assign FAILED/CLOSED tasks? From the code it looks that it is not an oversight.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.34 (was: 1.33)

My inclination is that failed/closed tasks shouldn't be assigned, but maybe there is a clue as to some other case?

The assignTask docstring says:

Specify force=True to assign a non-free task

I think this mainly refers to re-assigning a task that may already be running elsewhere.

The code applies essentially no sanity checks in the force case.

All comments about the behavior of force date back to before koji was made public.

The pre-koji commit message from 2006 that added the force option says:

allow tasks to be freed, reassigned and canceled by admins

So I'm not detecting any intent to assign an already completed task.

Note that any change here will probably conflict with the scheduler work

Delaying after scheduler.

Metadata Update from @tkopecek:
- Issue set to the milestone: None (was: 1.34)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3665

Please continue any further discussion there.

Metadata