#3971 Do 'dnf group install' instead of 'dnf groupinstall'
Closed: Fixed by tkopecek. Opened by praiskup.

The DNF5 alias groupinstall -> group install has not been added to dnf5 (yet?) and it seems to be hardcoded into Koji.

Do you think we could allow Koji configuration so that, if dnf5 is used, group install is used?


Related to https://fedoraproject.org/wiki/Changes/BuildWithDNF5

We are a bit in a hurry, it would be really nice to have a patch for this by 2024-01-16
so we have a chance to at least downstream-patch Fedora Koji instance (@kevin confirmed that, if the patch was easy enough, this is doable).

We'd like to have this resolved before the mass-rebuild of F40 on 2024-01-17. WDYT?

+1, this is theoretically fixable in DNF 5 instead, but Koji is the best place to make this change. DNF 5 does not aim to be argument-for-argument compatible with DNF 4.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.35

PR #3974

Hello folks,

do we have any updates on this? I checked the {PR} mentioned above as well; I'm looking to have it in before mass rebuilds occur.

Temporary solution is what fedora did - just apply this patch if you have only dnf-based builds. It will be (highly probably) compatible with final solution in 1.35.

I believe @kevin did it yesterday (according to matrix)

Yeah, sorry for not communicating that. I created a updated koji package with the patch and applied it to all the builders.

Did dnf have a good reason for making such a backwards incompatible change?

It's not a change. DNF5 is a rewritten software that did not implement all the sub-commands/options that were available in DNF4.

in #3974 we're planning to side step these variations by instead using:

config_opts['chroot_setup_cmd'] = 'install @build'

afaict, this will work for both dnf5, older dnf, and any yum that we still care about. Currently shipped fedora and epel configs use the same.

If anyone sees a problem with this approach, please comment on #3974

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Metadata Update from @mfilip:
- Issue untagged with: testing-done

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Commit d5803139 fixes this issue

Commit 4ad92b5c relates to this ticket

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3971

Please continue any further discussion there.

Metadata
Related Pull Requests