koji

#4055 Unreachable code in (at least) kojid
Closed: Fixed by tkopecek. Opened by tkopecek.

Closed: Fixed
Reopen Issue

In main loop we're catching RetryError after AuthError. The first one is subclass of the other, so it is never caught.

https://pagure.io/koji/blob/master/f/builder/kojid#_177

ah yes, I noticed this the other day too

Metadata Update from @mikem:
- Custom field Size adjusted to None

I might have a fix on a branch somewhere already

ah yes, some partial work here on kojid unit tests -- https://pagure.io/fork/mikem/koji/commits/kojid-main-tests

I was writing additional unit tests for #4044 and found the issue. Didn't add it to the pr because the fix is really a separate change

Filed a pr for those unit tests -- #4118

Commit cd93749a relates to this ticket

Commit d68a9273 fixes this issue

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.35
- Issue tagged with: no_qe

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4055

Please continue any further discussion there.
Metadata
None

no_qe tech-debt

None
None
Normal
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.