#4102 koji-1.34.1.tar.bz2 seems missing some things?
Closed: Invalid by mikem. Opened by kevin.

This may be some kind of error on my part, but I am seeing a number of things missing from the 1.34.1.tar.bz2 that are in git and have been a while...

for example:

docs/source/mock_config.rst
plugins/builder/scmpolicy.py
tests/test_builder/test_get_next_task.py

but also a number of commits, like 60b71020f

am I just going crazy here? :)


I have confirmed that the published tarball for 1.34.1 matches the content for the koji-1.34.1 tag.
https://releases.pagure.org/koji/

Please note that the 1.34.1 release is on the koji-1.34-updates branch, not the master branch. This is because we shifted from planning a 1.35 release to a 1.34.1 release. Not all of the work on the master branch was suitable for an update to 1.34. Only a subset of the changes on the master branch were included.

$ git log --oneline --decorate koji-1.34.0..koji-1.34.1
798c5e77 (HEAD, tag: koji-1.34.1, origin/koji-1.34-updates) PR#4090: Koji 1.34.1 release notes
959d0723 PR#3891: Don't try to resolve server version for old hubs
225cb44d PR#3975: Bandit [B411]: use defusedxml to prevent remote XML attacks
fb280e93 PR#4088: tests: py3 versions compatibility fixes
2605e799 PR#4069: add requirement: defusedxml in setup.py
6a324f43 PR#4056: avoid explicit rowlock in taskWaitCheck
574224ec PR#4052: fix formatting of rpm in title
b673b37d PR#4043: --limit from scheduler-logs/info
e70b62aa PR#4041: Use host maxtasks if available
963a8515 PR#4037: Fix temporary cg_import.log file path
b033ab2d PR#4032: implicit task refusals
b5453665 PR#4018: Fix scheduler log ordering
e2bf2a7b PR#4015: provide draft flag to build policy
598e8c31 PR#4005: Fix bandit "nosec" comments
2c15443f PR#3999: Have builders refuse repo tasks if they can't access /mnt/koji
e63c679f PR#3998: typo in set_refusal
6d583fb5 PR#3989: Oz: don't hardcode the image size unit as 'G'
af515b8e PR#3996: Document draft builds
1d87532f PR#3942: policy_data_from_task_args: set target to None when it doesn't exist
a28f14bb PR#3931: web: add some handy links for module builds
baf6c37b PR#3992: Remove rpm-py-installer, update test docs and update Dockerfiles
2daea147 PR#4012: rmtree: use fork

Commit 60b71020 was part of PR#4023 (split out buildroot log watching logic), which was not included. It is a more invasive change than the rest. Similarly the files you note were added in PRs that were not pulled in.

Metadata Update from @mikem:
- Custom field Size adjusted to None

Metadata Update from @mikem:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

Ah ha. So it was me doing something dumb. ;)

Thanks for the info!

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4102

Please continue any further discussion there.

Metadata