koji

#4193 repoInfo no longer accepts None
Closed: Fixed by tkopecek. Opened by mikem.

Closed: Fixed
Reopen Issue

the repoInfo call was rewritten for the kojira work, and the input validation rejects None. Previously it would allow it and would not error with strict=False.

The webui relies on this. E.g. changes in PR #3455

Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.35
- Issue tagged with: no_qe

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.35.1 (was: 1.35)

Easy replication

[mikem@localhost koji]$ ./devtools/fakehub repoInfo None
...
xmlrpc.client.Fault: <Fault 1019: "Invalid type, expected type <class 'int'>">

Whereas for koji-1.34, it returns None.

Make a runroot task with a numeric repo_id param will result in an error on taskinfo page. E.g.

devtools/fakehub -u mikem makeTask runroot "[10000000, 'x86_64', 'echo ok']"

...

 An error has occurred on the main server. This could be a software bug, a server configuration issue, or possibly something else.
koji.ParameterError: Invalid type, expected type <class 'int'>
Traceback (most recent call last):
  File "/usr/share/koji-web/scripts/wsgi_publisher.py", line 391, in handle_request
    result = func(environ, **data)
             ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/koji-web/scripts/index.py", line 751, in taskinfo
    params['repo'] = server.repoInfo(params.pop('repo_id'))
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/koji/__init__.py", line 2536, in __call__
    return self.__func(self.__name, args, opts)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/koji/__init__.py", line 3120, in _renew_expired_session
    return func(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/koji/__init__.py", line 3199, in _callMethod
    raise err
koji.ParameterError: Invalid type, expected type <class 'int'>
Edited by mikem

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.35 (was: 1.35.1)

Commit 9ae1c89c fixes this issue

Metadata Update from @mikem:
- Issue set to the milestone: 1.35.1 (was: 1.35)

Metadata Update from @mikem:
- Issue set to the milestone: 1.35.2 (was: 1.35.1)

Metadata Update from @mikem:
- Issue set to the milestone: 1.35 (was: 1.35.2)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4193

Please continue any further discussion there.
Metadata
None

easyfix no_qe

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.