We have recently updated a Koji deployment to 1.35, and observed that the latest symlink was not being created whenever a repository was generated.

Reviewing the code, this appears to be because the check for a newer repository in symlink_if_latest is matching the current repository, thus it always thinks there is a newer one:

# only symlink if we are actually latest
    clauses = [
        ['tag_id', '=', repo['tag_id']],
        ['state', '=', koji.REPO_READY],
        ['create_event', '>=', repo['create_event']]]
    if repo['dist']:
        clauses.append(['dist', 'IS', True])
    else:
        clauses.append(['custom_opts', '=', '{}'])
    query = RepoQuery(clauses)
    newer = query.execute()
    if newer:
        logger.debug('Skipping latest symlink, %i newer repos found', len(newer))
        return False

To fix this I think it needs one of the following:

• The criteria for create_event should be simply > rather than >= (this is the temporary fix we have put in place on our deployment which seems to be working)
• Add extra criteria to ignore the repository we are currently considering symlinking

I'm happy to create a PR for either of these approaches, but would appreciate someone more familiar with the code to suggest which is the best one to take...