Note that I am using Koji from epel on RHEL7.

I've made some PR #461 proposal. Syntax of allowed_scms changed from original patch, so it is no more usable directly + there is no request for Perforce support anymore. So only port part added. If we want to go this way (@mikem?), then I could add some more tests.

I see a couple potential problem cases related to no-default ports. I wonder which of the following are problems you need to solve.

1) Server uses non-default port. User specifies that port in their scm url. However, because of the use of colons in the allowed scms setting, the admin cannot add an entry for host:port (and host:port is what the current code will try to match for such urls).

2) Server runs on multiple ports for given host and you want to allow one but not the other (or use different scm settings for one).

3) Server runs on non-default port and you don't want the user to have to specify the information in the scm url, but instead have kojid add it.

Regarding 1 (and maybe 2), note that the host and repository values in the allowed_scms setting are interpreted as patterns, so you could use ? instead of : in the host field. It's not perfect, but it appears to be a viable workaround.

Problem 1 is the one I'm reporting, so hopefully that's the one the patch tries to solve. Using a colon does seem to make the parsing more difficult, but it looks like the proposed patch addresses that.

In that case, can you solve problem 1 with the workaround above? (Using ? in the host pattern instead of a literal :)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/428

Please continue any further discussion there.