#4282 wait-repo --build doesn't require build to be latest anymore
Opened by mikem. Modified

Before 1.35, the wait-repo command would call koji.util.checkForBuilds with latest=True, which requires that the build be latest in the tag, not merely present. In 1.35 this command has been rewritten to use RepoWatcher. It still calls checkForBuilds underneath, but without latest=True


This is a bit complicated because previous code did different things in different places. The only place we passed latest=True was in koji_cli.lib.wait_repo. The waitrepo task and getRepo method used on the builders did not, so koji wait-repo --build=NVR didn't quite do the same thing as koji build --wait-build=NVR.

AIUI, the "mere inclusion is good enough" default comes from chain-build, where we were likely concerned about being tolerant if a newer build got tagged during processing.

TBH, I think being tolerant of such a case is still a concern

Metadata Update from @mikem:
- Custom field Size adjusted to None

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4282

Please continue any further discussion there.

Metadata