koji

#4320 Tests failing
Closed: Fixed by tkopecek. Opened by alisboav.

Closed: Fixed
Reopen Issue

Last year, we tried to update to version 1.35.1-1, but some tests failed.
We are waiting for a new release of koji, but I tried running the tests again using the master version and got the following:

AlmaLinux9 machine:

=========================== short test summary info ============================
FAILED tests/test_plugins/test_kiwi_builder.py::TestKiwiBuildTask::test_get_nrvp_correct - TypeError: NamedTemporaryFile() got an unexpected keyword argument 'delete_...
FAILED tests/test_plugins/test_kiwi_builder.py::TestKiwiBuildTask::test_get_nrvp_invalid_xml - TypeError: NamedTemporaryFile() got an unexpected keyword argument 'delete_...
ERROR tests/test_builder/test_newRepo.py
ERROR tests/test_plugins/test_builder_scmpolicy.py
============= 2 failed, 2677 passed, 2 errors in 61.53s (0:01:01) ==============

AlmaLinux8 machine:

=========================== short test summary info ============================
FAILED tests/test_docs_version.py::TestDocsVersion::test_docs_version - Index...
FAILED tests/test_api/test_api.py::TestAPICompat::test_api_compat - Exception...
FAILED tests/test_hub/test_repo_requests.py::TestQueueTask::test_queue_task_event
FAILED tests/test_hub/test_repo_requests.py::TestUpdateEndEvents::test_event_cache
FAILED tests/test_hub/test_repo_requests.py::TestUpdateEndEvents::test_update
FAILED tests/test_hub/test_repo_requests.py::TestAutoRequests::test_auto_lag_window
FAILED tests/test_hub/test_repo_requests.py::TestGetRepo::test_get_repo_at_event
FAILED tests/test_hub/test_repo_requests.py::TestGetRepo::test_get_repo_min_event
FAILED tests/test_hub/test_repo_requests.py::TestRequestRepo::test_request_last
FAILED tests/test_hub/test_repo_requests.py::TestRequestRepo::test_request_priority
FAILED tests/test_hub/test_repo_requests.py::TestDefaultMinEvent::test_lag_override
FAILED tests/test_hub/test_repo_requests.py::TestDefaultMinEvent::test_lag_override_invalid
FAILED tests/test_hub/test_repo_requests.py::TestDefaultMinEvent::test_simple_lag
FAILED tests/test_hub/test_repo_requests.py::TestDefaultMinEvent::test_tag_older
FAILED tests/test_hub/test_repo_requests.py::TestDefaultMinEvent::test_window
FAILED tests/test_hub/test_repo_requests.py::TestExports::test_require_perm
FAILED tests/test_hub/test_wrapper_rpm.py::TestWrapperRPM::test_repo_id_ignored
FAILED tests/test_lib/test_utils.py::TestRmtree::test_rmtree_child - TypeErro...
FAILED tests/test_plugins/test_kiwi_builder.py::TestKiwiBuildTask::test_get_nrvp_correct
FAILED tests/test_plugins/test_kiwi_builder.py::TestKiwiBuildTask::test_get_nrvp_invalid_xml
FAILED tests/test_plugins/test_kiwi_builder.py::TestKiwiBuildTask::test_handler_correct
FAILED tests/test_plugins/test_kiwi_builder.py::TestKiwiBuildTask::test_no_arches
ERROR tests/test_builder/test_newRepo.py
ERROR tests/test_plugins/test_builder_scmpolicy.py
============ 22 failed, 2657 passed, 3 warnings, 2 errors in 25.64s ============

It seems to also depend on the operating system.
I'm wondering if we are missing some step when running the tests.
The procedure I am following is:

yum install -y glibc-langpack-en
dnf install -y gcc python3-requests-gssapi python3-librepo python3-prometheus_client
yum install python3-devel
dnf install python3-pip
pip3 install tox
git clone https://pagure.io/koji.git
cd koji
make test3

Can you please take a look?

Kind regards,
Marta

You haven't clearly specified which sources you have. Your inclusion of an rpm release value after the version suggests you are using sources from a source rpm, which could contain patches.

If I checkout version 1.35.1 from git, make test3 succeeds for me.

There were some unit test failures in some environments with some of the post 1.35.1 changes (there has actually been a lot of churn in the unit tests in that time). These should be resolved in current master branch and upcoming 1.35.2 release.

Metadata Update from @mikem:
- Custom field Size adjusted to None

If I checkout to version 1.35.1, the make test3 still fails for me.
Can you please let us know which environment should we use to run the tests?

Metadata Update from @mikem:
- Issue set to the milestone: 1.36

Metadata Update from @tkopecek:
- Issue tagged with: no_qe

Commit 9e2e7023 fixes this issue

Metadata Update from @mikem:
- Issue set to the milestone: 1.35.3 (was: 1.36)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4320

Please continue any further discussion there.
Metadata
None

no_qe

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.