koji

#4338 Better handling of sbindir macro
Closed: Fixed by mikem. Opened by mikem.

Closed: Fixed
Reopen Issue

This is a follow-up to #4296, which was closed by #4297

There is some indication that the fix from #4297 might have some unexpected side effects, but in any case, we want to have a better fix for this.

Current candidate is in #4335 (based on #4324)

Metadata Update from @mikem:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.35.3

Thanks. I'll try and test 4335 here soon.

ok. So, it seems like the thing I was seeing with all the /usr/bin/ items duplicated has nothing to do with this change, and instead seems to be a rpm thing.
ie, if I build for rawhide I see this, if I build for f41 I do not.

So, do you recall why we are specifying /usr/bin/ in files for the main koji package? There's only one thing that should be there... the koji cli. It seems more correct to just say usr/bin/

I like this solution better than the initial one because it just works for older releases where sbindir is /usr/sbin and newer ones where it's /usr/bin.

Sorry this took so long. I was on PTO, but also it's a bit anoying to compare the fedora spec to the shipped one since I pulled python2 support out. I suppose you still need that to support super old clients or something?

Metadata Update from @julian8628:
- Issue priority set to: None (was: Normal)

Metadata Update from @julian8628:
- Issue priority set to: Normal

Metadata Update from @tkopecek:
- Issue tagged with: testing-basic

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Commit b21cb0ba fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4338

Please continue any further discussion there.
Metadata
None

testing-basic testing-done

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.