#4345 Make cg reservation epoch check a bit better
Opened by mikem. Modified

The epoch check for when importing with a reservation requires the epoch match. However, there is a subtle gotcha there. If the epoch value is given as a string (e.g. "epoch": "0") in the initial reservation, this value is implicitly converted to an int by the data insert. The import check does not do this and will complain of a mismatch (because "0" != 0).

While technically, the epoch value should be given as an integer in the json, it's straightforward to be tolerant here.

I also note that the epoch is not compared if it is absent from the import metadata, even if one was specified in the reservation. This seems counter to the intent.


This is a followup to #4125

Metadata Update from @mikem:
- Custom field Size adjusted to None

Metadata Update from @mikem:
- Issue set to the milestone: 1.36

Metadata Update from @julian8628:
- Issue priority set to: None (was: Normal)

Metadata Update from @julian8628:
- Issue priority set to: Normal

Metadata Update from @mikem:
- Issue set to the milestone: 1.36.1 (was: 1.36)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4345

Please continue any further discussion there.

Metadata