#4356 Some of unit tests fails with pytest==8.3.5
Closed: Fixed by mikem. Opened by jcupova.

When pytest==8.3.5 is installed, tox -e py3 is not working. In tox file is setup env variable COLUMNS=80 https://pagure.io/koji/blob/master/f/tox.ini#_26 , but not used. Also not working, when we export variable COLUMNS before run tests:
$ export COLUMNS=80
$ echo $COLUMNS
80
$ tox -e py3
....
....
================ 38 failed, 2675 passed, 34 warnings in 21.76s =================
py3: exit 1 (22.23 seconds) /home/jlibrova/Work/koji> python -m pytest -n auto --cov --cov-config .coveragerc3 --cov-report=html pid=2554900
py3: FAIL code 1 (31.05=setup[8.72]+cmd[0.03,0.08,22.23] seconds)
evaluation failed :( (31.10 seconds)
$ echo $COLUMNS
133

With pytest==8.3.4 unit tests are working correctly.


Is this still happening for you? I tend to see errors like this when I run pytest directly (on f41 without passing COLUMNS), but running through tox seems to avoid it for me.

Running pytest directly with explicit COLUMNS=80 also prevents this for me.

Metadata Update from @mikem:
- Custom field Size adjusted to None

@mikem yes, still the same problem. When I run tests in master version of Koji, it returns 38 failed tests and all related to test help message. And all errors is related to line length. Still same problem. I can set COLUMNS manually, but run tox -e py3 or make tests3 and same problem. COLUMNS is rewrited to actual length of terminal. And I can see that we have newer pytest (pytest-8.4.1) and this is the same problem.

Commit c37b7dcd fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4356

Please continue any further discussion there.

Metadata
Related Pull Requests