#4526 BaseTaskHandler localPath() method unexpected behaviour
Opened by evilcica. Modified

While developing a kojid plugin, I have noticed that every call to self.localPath() ends up downloading files despite the main Koji volume being accessible locally. This is inconsistent with the comment in the function which implies that the local mount will be used before trying to download.

https://pagure.io/koji/blob/a82be2a04824083305e76b4184d9d7dcc70b3e04/f/koji/tasks.py#_511

In my testing, both self.options.topurl and self.options.topdir are set, so the method always chooses to download instead of using the topdir.
Is this intended behaviour, making the comment wrong? Or is the comment the intended behaviour, and therefore the code is wrong? Either way, I'm willing to provide a PR to fix this, I just need to know which way to go.


This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4526

Please continue any further discussion there.

Metadata