#4552 flag data can leak across checks
Opened by mikem. Modified

The flag action was added in 1.36.0 and allows policies, as an action, to set a flag that can be tested later in the policy. However, in some cases the flag data can leak across policy invocations.

This only happens if code invoking the policy check recycles the policy data that it passes in. In Koji, this can currently happen in the following places:

  • in make_task, the same policy_data is used for the channel policy and priority policy checks
  • in PolicyTest, the check passes its data through to the subpolicy
  • in moveAllBuilds, the same policy_data dictionary is reused and updated for each build

All other policy checks appear to create fresh data for each check.


https://pagure.io/koji/pull-request/4553

Metadata Update from @mikem:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue tagged with: testing-basic

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4552

Please continue any further discussion there.

Metadata
Related Pull Requests