#467 drop old ssl support
Closed: Fixed Opened by mikem.

I'd like to drop the old ssl code from Koji. We've been using python-requests for a couple releases, which is just a better all around approach.

[side note: we'll still keep the support on the legacy-py24 branch, since requests does not support py24]

Right now, we only use this old code in the following cases:

  1. requests is not present
  2. the use_old_ssl option is set

Dropping this support would allow us to remove some rather ancient and hackish code.


:thumbsup:

We may target as early as 1.14 for this, so if anyone out there is relying on use_old_ssl, speak up now. Let's make sure python-requests is working for you.

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.14

Starting PR for testing: #498

See also: https://lists.fedorahosted.org/archives/list/koji-devel@lists.fedorahosted.org/thread/UAVXNGGNZVCFBQYTHXXX3BYINWQ7LAPM/

Given that we have at least one user relying on it, and removing the code is not critical, I think we should wait until 1.15 at least

Metadata Update from @mikem:
- Issue set to the milestone: 1.15 (was: 1.14)

PR #597 adds deprecation warnings

Commit b27fcec5 relates to this ticket

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.16 (was: 1.15)

Commit e399f69a fixes this issue

Commit 8f22069f relates to this ticket

Metadata Update from @tkopecek:
- Issue tagged with: deprecation

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/467

Please continue any further discussion there.

Metadata