koji

#648 Consolidate rmtree usage
Closed: Fixed Opened by tkopecek.

Closed: Fixed
Reopen Issue

koji.util.rmtree and koji.tasks.safe_rmtree handle very similar task. Merge them to koji.util. Also find all unsafe shutil.rmtree usage.

My initial instinct is that safe_rmtree should remain a separate function, but that it should call koji.util.rmtree for the removal portion.

and yes, shutil.rmtree should be replaced in the main code, though I think it is ok in the unit tests
Edited by mikem

PR #658

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.15

Commit 423eac9e fixes this issue

Commit 5b23fb16 relates to this ticket

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/648

Please continue any further discussion there.
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.