#871 API Call groupPackageListUnblock don't unlock package list which was block by groupPackageListBlock
Closed: Invalid by mikem. Opened by jcupova.

Steps to Reproduce:

Run groupPackageListAdd(tag, groupname, pkg)
Run groupPackageListBlock(tag, groupname, pkg)
Run groupPackageListUnblock(tag, groupname, pkg)

Actual result:

In getTagGroups don't show unblocked package list.

Expected result:

In getTagGroups show unblocked package list.


PR #872

This is confusing, but it is not a bug.

  • Adding creates an entry.
  • Blocking creates a blocking entry. In this case the block is created in the same tag as the original entry, so the blocking entry replaces it.
  • Unblocking removes the blocking entry.

Blocking prevents entries from being inherited. If you had added the original entry in a parent tag instead, then unblocking would have allowed that inheritance to resume. However, because you used the same tag, the act of blocking overwrote the original entry.

Metadata Update from @mikem:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

It is really very confusing. Isn't it worth checking that there is previous unblocked record (new.create_event == previous.revoke_event) and in that case rehabilitate previous record? It behaves this way only in case of same tag/group without inheritance.

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/871

Please continue any further discussion there.

Metadata
Related Pull Requests