koji

#913 hub uses absolute symlinks for imported work files
Closed: Fixed Opened by mikem.

Closed: Fixed
Reopen Issue

When the hub moves task files into place, it normally replaces the original upload location with a symlink. This is done mainly so that the files still appear on the task page after a build is imported.

However, the hub is using absolute symlinks to do this. This doesn't necessarily cause a problem, but it could if:

  • the topdir location changes on the hub
  • a client is using a different topdir setting than the hub

There are several places we do something like this:

safer_move(fn, dest)
os.symlink(dest, fn)

I think it would be worth wrapping this up in a function (e.g. move_and_symlink), and using os.path.relpath to calculate the symlink target.

Metadata Update from @mikem:
- Issue tagged with: easyfix

PR #920

Commit 0e043e1e fixes this issue

Commit 6a6f90be fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/913

Please continue any further discussion there.
Metadata
None

easyfix

None
None
Normal
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.