Issue #956: package ownership changes should not trigger repo regens - koji

koji

#956 package ownership changes should not trigger repo regens

Closed: Fixed Sep 26, 2019 by tkopecek. Opened Jun 1, 2018 by mikem.

Package ownership does not affect repo generation at all, yet a change to ownership will trigger a repo regen since that data is stored in the tag_packages table alongside other data that does.

There are a few ways we could address this, but probably the right way would be to separate out the package ownership data into its own (still versioned) table and have kojira disregard that table for regens.

Metadata Update from @mikem:
- Issue tagged with: discussion

Jun 1, 2018

tkopecek commented Jun 6, 2018

Second option could be check all other tables first, then tag_packages in the end. If in this point change is detected, further query_history could be run to check type of changes. It introduces new and more expensive queries, but doesn't need changes in any other koji part. tag_package_owner is probably cleaner solution, but will need changes in more places and maybe also some semantics (what changed package mean by default now?)

Metadata Update from @tkopecek:
- Issue untagged with: discussion
- Issue set to the milestone: 1.19

May 30, 2019

tkopecek commented May 30, 2019

PR #1473

tkopecek commented Aug 29, 2019

Commit 1e35e60c fixes this issue

tkopecek commented Aug 29, 2019

Commit 3de3f61f fixes this issue

Metadata Update from @julian8628:
- Custom field Size adjusted to None
- Issue status updated to: Open (was: Closed)

Sep 6, 2019

julian8628 commented Sep 6, 2019

a small fix for schema.sql #1643