Fixes: https://pagure.io/koji/issue/998
None target means null-target, in koji-shadow it could be None. I think if there's no target in parameters, target shouldn't be put in policy_data
None
policy_data
Wondering if hastarget is necessary, can we use if target instead?
if target
Add test (note for me)
We should not add a target value where there is none defined. No target defined is different from an explicit target value of None. I think instead that we should have some of the tests handle this more gracefully.
has
target
rebased onto 3d9445c33a4db4c5b6be84417f4e315749dbf787
I've fixed the PR. @mikem Do we want to track those tests' improvements in separate issue?
Commit cd761147 fixes this pull-request
Pull-Request has been merged by mikem
I;ve filed #1038 and #1040 for the policy test follow ups
Fixes: https://pagure.io/koji/issue/998