koji

#1014 cli: preserve build order in clone-tag
Merged by mikem. Opened by julian8628.
julian8628/koji issue/960  into  master

Download 1014.patch

fixes #960

and
- fix group pkg list cloning
- preserve group cloning order

2 new commits added

  • preserve group order
  • [clone-tag] preserve build order and fix group cloning

I had a few tweaks during review. They don't change behavior, just trying to make the code a little clearer.

https://github.com/mikem23/koji-playground/commits/pagure/pr/1014

Can you have a look and pull these in if they make sense to you?

rebased onto ee1ec497fc232375cec313d5f12384db1e1cbe5b

thanks @mikem
updated

1 new commit added

  • rename var, tweak logic, and add comments for clarity

1 new commit added

  • delete all other builds when latest_only and dsttag exists

@mikem I made one more change for the case latest_only = True, please review.
after checking the logic. I found when latest_only = True, to keep the behavior much like clone, we'd better untag all other builds and only leave the latest one per pkg.

And if only get the latest builds in dsttag. tagging might fail, for example:

old --> new
srctag: P-A
dsttag: P-A, P-B, P-C
in previous version of this PR, it will untag P-C, and then tag P-A, it will fail without force=True

+1
makes sense

Commit 21c5bd31 fixes this pull-request

Pull-Request has been merged by mikem

Metadata Update from @julian8628:
- Pull-request tagged with: testing-ready
Metadata
None

testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.