Won't Fedora need an AMQP based message plugin soon? I'm not saying keep this one (because I've had a ton of trouble with qpid and don't like it...), but we probably might want a new amqp plugin using pika instead (since pika is well-maintained).

Isn't proton plugin sufficient for that?

Huh, I didn't realize both of them were AMQP plugins. But no, Qpid-proton is AMQP 1.0, which is not what Fedora is deploying. And apparently this one won't work either, since it doesn't support the right AMQP version, either...

RabbitMQ uses AMQP 0-9-1, which as far as I'm aware, is apparently supported only by pika.

@kevin Is Fedora going to need this plugin?

No, we use a fedmsg plugin currently ( https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/koji_hub/templates/fedmsg-koji-plugin.py )

I imagine we will port that to our new fedora messaging setup, but we don't use this one as far as I know.

Adding @jcline and @abompard for more comment if I got something wrong...

I imagine we will port that to our new fedora messaging setup, but we don't use this one as far as I know.

Sounds right to me. In theory rabbit has a plugin for AMQP 1.0 support, but porting that plugin to the pika-based client should be trivial.

@jcline Could we get a generic pika-based AMQP plugin that happens to work with new fedora messaging that could be upstreamed?

That is certainly possible. fedora-messaging is just boilerplate around pika to enforce certain JSON schema and handle the details of setting up the connection to the broker. What's the use case you have where taking the fedora plugin won't work, but you also need AMQP 0.9.1 support?

@jcline Usage of Koji in Mageia, maybe also CentOS with CBS, and some private instance systems too.

Commit ecfcb5b9 fixes this pull-request