:thumbsup: (but it's mostly my code)

I take it you're happy with it, @tkopecek ?

Can we please just drop the bundled mergerepos code and switch to mergerepos_c?

@ngompa - we can't do it for now, as mergerepos_c doesn't provide needed behaviour. But I'm planning to write a patch for it making same things., so we can use it also for this mode.

It doesn't? mergerepos_c has a --koji mode that is intended to behave the same way as our embedded one...

@ngompa - yes, mergrepo_c with --koji option is used when use_createrepo_c is set to true. In this PR we're adding different mode ("simple") for merging external repos, which allows us to use "malformed" repodata. In such case --koji behaviour should be limited to create pkgorigins file, but not to enforce other checks of that mode.

So, for normal usage (before this patch) is mergerepo_c used already. See switch-part in https://pagure.io/koji/pull-request/1066#_1,36

Commit e08e279f fixes this pull-request